docs: update docs for new lti ui#1439
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @rpenido! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
rpenido
force-pushed
the
rpenido/fal-4323/update-lti-docs
branch
from
d3e4b44 to
190851b
Compare
rpenido
force-pushed
the
rpenido/fal-4323/update-lti-docs
branch
from
190851b to
a0a3f3d
Compare
|
@rpenido I pushed a commit to fix typos and spacing issue in table, lets see if the CI passes now. |
|
@rpenido @navinkarkera - please ping me for review when this is out of draft! |
|
This is ready for review @sarina! |
sarina
left a comment
sarina
left a comment
There was a problem hiding this comment.
This looks great, thank you.
If these documents have been reviewed & are accurate, please update the maintenance chart - https://docs.openedx.org/en/latest/documentors/references/doc_maintenance.html#maintenance-chart - if there are docs in this diff that have not been reviewed for accuracy... could they be? So that we have reviewed docs for Verawood. Thank you!
rpenido
force-pushed
the
rpenido/fal-4323/update-lti-docs
branch
from
73f0434 to
20d53e3
Compare
Co-authored-by: Sarina Canelake <sarina@axim.org>
rpenido
force-pushed
the
rpenido/fal-4323/update-lti-docs
branch
from
20d53e3 to
04fba0a
Compare
musaabhasan
left a comment
musaabhasan
left a comment
There was a problem hiding this comment.
The updated LTI field names are helpful for keeping the docs aligned with the current Studio UI. I left one privacy wording note around the data-sharing notice so educators do not confuse a disclosure field with the actual controls that determine whether learner identifiers are shared.
| identify problems quickly and accurately for analysis. | ||
|
|
||
| * - LTI Application Information | ||
| * - Data Sharing Notice |
There was a problem hiding this comment.
It would help to clarify that this field is a learner-facing disclosure, not the control that enables or disables sharing. Since the same table later documents Share Email, Share Username, and Share Full Name, educators could otherwise read this as the setting that determines whether identifiers are sent. A sentence such as "This notice does not control whether data is shared; use the sharing settings below for that behavior" would make the privacy boundary clearer.
6 participants
This PR updates the LTI Consumer block documentation with the new UI and field names.